netdev - Re: [RFC] div64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Feb 2007 13:28:34 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RFC] div64_64 support

On Mon, 26 Feb 2007 21:09:26 +0100 (MET)
Jan Engelhardt <jengelh@...ux01.gwdg.de> wrote:

> 
> On Feb 23 2007 17:05, Stephen Hemminger wrote:
> >
> >Since there already two users of full 64 bit division in the kernel,
> >and other places maybe hiding out as well. Add a full 64/64 bit divide.
> >
> >Yes this expensive, but there are places where it is necessary.
> >It is not clear if doing the scaling buys any advantage on 64 bit platforms,
> >so for them a full divide is done.
> >
> >---
> > include/asm-arm/div64.h      |    2 ++
> > include/asm-generic/div64.h  |    8 ++++++++
> > include/asm-m68k/div64.h     |    2 ++
> > include/asm-mips/div64.h     |    8 ++++++++
> > include/asm-um/div64.h       |    1 +
> > include/asm-xtensa/div64.h   |    1 +
> > lib/div64.c                  |   22 ++++++++++++++++++++++
> > net/ipv4/tcp_cubic.c         |   22 ----------------------
> > net/netfilter/xt_connbytes.c |   16 ----------------
> > 9 files changed, 44 insertions(+), 38 deletions(-)
> 
> Actually, there is udivdi3 support in the kernel
> 
> ./arch/arm26/lib/udivdi3.c
> ./arch/sh/lib/udivdi3.c
> ./arch/sparc/lib/udivdi3.S
> 
> should not this be consolidated too?


Hmm. Those are the GCC internal versions, that are picked up but
doing divide in place. Do we want to allow general 64 bit in kernel to
be easily used? It could cause sloppy slow code, but it would look
cleaner.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html