lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Feb 2007 12:11:02 +0530 From: Amit Kale <amitkale@...xen.com> To: Stephen Hemminger <shemminger@...ux-foundation.org> Cc: Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org Subject: Re: [PATCH] netxen: do_rom_fast_write error handling Ah.. missed that. Thanks. -Amit On Tuesday 27 February 2007 04:21, Stephen Hemminger wrote: > Compiler warning spots real error! > > The function do_rom_fast_read called in do_rom_fast_write can fail > and leave data1 unset. This causes a compile warning. > The correct thing is to propagate the error out. > > Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org> > > --- > drivers/net/netxen/netxen_nic_init.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > --- pktgen.orig/drivers/net/netxen/netxen_nic_init.c 2007-02-26 > 14:45:46.000000000 -0800 +++ > pktgen/drivers/net/netxen/netxen_nic_init.c 2007-02-26 14:46:37.000000000 > -0800 @@ -499,7 +499,10 @@ > while(1) { > int data1; > > - do_rom_fast_read(adapter, addridx, &data1); > + ret = do_rom_fast_read(adapter, addridx, &data1); > + if (ret < 0) > + return ret; > + > if (data1 == data) > break; - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists