netdev - Re: [PATCH 1/2] [TCP]: Add two new spurious RTO responses to FRTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070227.101026.89037327.davem@davemloft.net>
Date:	Tue, 27 Feb 2007 10:10:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] [TCP]: Add two new spurious RTO responses to FRTO

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Tue, 27 Feb 2007 17:50:06 +0200 (EET)

> New sysctl tcp_frto_response is added to select amongst these
> responses:
> 	- Rate halving based; reuses CA_CWR state (default)
> 	- Very conservative; used to be the only one available (=1)
> 	- Undo cwr; undoes ssthresh and cwnd reductions (=2)
> 
> The response with rate halving requires a new parameter to
> tcp_enter_cwr because FRTO has already reduced ssthresh and
> doing a second reduction there has to be prevented. In addition,
> to keep things nice on 80 cols screen, a local variable was
> added.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied to tcp-2.6, thanks!

I tidied up the coding style of the switch statement slightly.
So that it reads like this:

		switch (sysctl_tcp_frto_response) {
		case 2:
			tcp_undo_spur_to_response(sk);
			break;
		case 1:
			tcp_conservative_spur_to_response(tp);
			break;
		default:
			tcp_ratehalving_spur_to_response(sk);
			break;
		};

Thanks again.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html