netdev - Re: TCP minisock tcp_create_openreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 28 Feb 2007 11:06:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	acme@...stprotocols.net
Cc:	hidden@...abit.hu, netdev@...r.kernel.org
Subject: Re: TCP minisock tcp_create_openreq_child() typo?

From: "Arnaldo Carvalho de Melo" <acme@...stprotocols.net>
Date: Wed, 28 Feb 2007 09:10:10 -0300

> On 2/28/07, KOVACS Krisztian <hidden@...abit.hu> wrote:
> >
> >   Hi,
> >
> >   While reading TCP minisock code I've found this suspiciously looking
> > code fragment:
> >
> > - 8< -
> > struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req, struct sk_buff *skb)
> > {
> >         struct sock *newsk = inet_csk_clone(sk, req, GFP_ATOMIC);
> >
> >         if (newsk != NULL) {
> >                 const struct inet_request_sock *ireq = inet_rsk(req);
> >                 struct tcp_request_sock *treq = tcp_rsk(req);
> >                 struct inet_connection_sock *newicsk = inet_csk(sk);
> >                 struct tcp_sock *newtp;
> > - 8< -
> >
> >   The above code initializes newicsk to inet_csk(sk), isn't that supposed
> > to be inet_csk(newsk)?  As far as I can tell this might leave
> > icsk_ack.last_seg_size zero even if we do have received data.
> 
> Good catch!
> 
> David, please apply the attached patch.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Applied, thanks everyone.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html