lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Feb 2007 21:33:50 +0100 From: Eric Dumazet <dada1@...mosbay.com> To: David Miller <davem@...emloft.net> CC: netdev@...r.kernel.org Subject: Re: [PATCH 2/4]: Store retransmit queue packets in RB tree. David Miller a écrit : > commit c387760826bd71103220e06ca7b0bf90a785567e > Author: David S. Miller <davem@...set.davemloft.net> > Date: Tue Feb 27 16:44:42 2007 -0800 > > [TCP]: Store retransmit queue packets in RB tree. > > Signed-off-by: David S. Miller <davem@...emloft.net> > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index 4ff3940..b70fd21 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -18,6 +18,7 @@ > #include <linux/compiler.h> > #include <linux/time.h> > #include <linux/cache.h> > +#include <linux/rbtree.h> > > #include <asm/atomic.h> > #include <asm/types.h> > @@ -232,6 +233,8 @@ struct sk_buff { > struct sk_buff *next; > struct sk_buff *prev; > > + struct rb_node rb; > + > struct sock *sk; > struct skb_timeval tstamp; > struct net_device *dev; I am not sure this rb_node placement is optimal. rb lookups want to access rb_node and end_seq. They should be placed in the same cache line :) next/prev were at the begining of sk_buff, there is no such constraint for rb - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists