netdev - Re: [PATCH] bonding: make IGMP flooding on active-backup bonds configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702282239.l1SMdg22017137@death.nxdomain.ibm.com>
Date:	Wed, 28 Feb 2007 14:39:42 -0800
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Andy Gospodarek <andy@...yhouse.net>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: make IGMP flooding on active-backup bonds configurable 

Andy Gospodarek <andy@...yhouse.net> wrote:

>A while back the following change was made to the bonding code:
>
>commit df49898a47061e82219c991dfbe9ac6ddf7a866b
>Author: John W. Linville <linville@...driver.com>
>Date:   Tue Oct 18 21:30:58 2005 -0400
>
>    [PATCH] bonding: cleanup comment for mode 1 IGMP xmit hack
>    
>    Expand comment explaining MAC address selection for replicated IGMP
>    frames transmitted in bonding mode 1 (active-backup).  Also, a small
>    whitespace cleanup.
>    
>    Signed-off-by: John W. Linville <linville@...driver.com>
>    Signed-off-by: Jeff Garzik <jgarzik@...ox.com>
>
>In general this patch is good, but this tweaks that feature by allowing
>that functionality to be enabled and disabled.  This patch adds a new
>module option as well as a sysfs entry.  It sets the default to be the
>current behavior so existing users shouldn't notice any difference.

	Why would you want to turn this off?

	Also, I've got a replacement patch for this functionality that
seems to be better in all regards. It sends bonus IGMP joins when a
failover occurs, rather than simply duplicating them on all slaves (the
current system can leave switches in the dark if the slaves fail back to
the originals).  As chance would have it, I'm planning to post it as
part of a set in a a little while.

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html