lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 01 Mar 2007 01:57:40 +0100
From: Johannes Berg <johannes@...solutions.net>
To: jt@....hp.com
Cc: Greg KH <gregkh@...e.de>, Jarek Poplawski <jarkao2@...pl>,
"David S. Miller" <davem@...emloft.net>,
Linux kernel mailing list <linux-kernel@...r.kernel.org>,
netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.20] kobject net ifindex + rename
On Wed, 2007-02-28 at 16:51 -0800, Jean Tourrilhes wrote:
> I would prefer to fix the comment when this change actually
> happens. I prefer comments to refer to the current reality, rather
> than past/future situation.
Uh, no. device_rename is perfectly fine, even other people may use it in
the future.
> When you introduce wireless renaming, you
> will need to verify the whole chain anyway, so you might as well fix
> the comment while merging wireless renaming.
No again, device_rename is perfectly fine API, I shouldn't have to look
at it's internals to see if it's broken in my use case. Even if it's
only a broken comment.
I'm not going to respin your patches though, if this doesn't make it in
I don't care.
johannes
Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)
Powered by blists - more mailing lists