netdev - Re: [git patches] net driver fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703012001110.7832@woody.linux-foundation.org>
Date:	Thu, 1 Mar 2007 21:28:20 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jeff Garzik <jeff@...zik.org>
cc:	netdev@...r.kernel.org
Subject: Re: [git patches] net driver fixes

Ok, here's an interesting one: my e1000 card no longer worked for a while.

The green link-light blinks on/off once a second, and in time to that, my 
dmesg fills up with an endless supply of

	e1000: eth0: e1000_watchdog: NIC Link is Down
	e1000: eth0: e1000_watchdog: NIC Link is Up 100 Mbps Full Duplex, Flow Control: None
	e1000: eth0: e1000_watchdog: 10/100 speed: disabling TSO

and networking obviously doesn't actually work.

I tried to do bisection, but my log made no sense, since it seemed to say 
that the problem was introduced between git commits 2442d310 and bff288c1, 
and there aren't even any commits to drivers/net/ in that range!

SO...

It seems to be that what actually happened is that my switch got confused 
(I ended up just power-cycling the switch when I hit the "impossible" 
situation, and that seems to be what made it start working again, rather 
than any kernel changes due to bisection ;)

Regardless, the "spam the logs every second" is a *bad* idea. I'll try to 
see if I can re-create the problem (probably not), but I thought I'd 
report this message spamming regardless. If there really is some link 
problem, no way do I want to see a message about it every second for all 
eternity. Hmm?

Does this "once a second link issue" ring any bells for anybody? Suggested 
fixes? I realize people do want to know about link problems, but that was 
a bit excessive and since it happened with a reboot, I thought it was a 
kernel bug (it may still be - I'll have to try to recreate it, but my 
suspicion right now is that the reboot just caused some noise and/or link 
renegotiation on the ethernet link that was what actually confused my 
switch).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html