netdev - [PATCH] NET : convert network timestamps to ktime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703021538.41284.dada1@cosmosbay.com>
Date:	Fri, 2 Mar 2007 15:38:41 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	John find <linux.kernel@...e.fr>, netdev@...r.kernel.org
Subject: [PATCH] NET : convert network timestamps to ktime_t

We currently use a special structure (struct skb_timeval) and plain 'struct 
timeval' to store packet timestamps in sk_buffs and struct sock.

This has some drawbacks :
- Fixed resolution of micro second.
- Waste of space on 64bit platforms where sizeof(struct timeval)=16

I suggest using ktime_t that is a nice abstraction of high resolution time 
services, currently capable of nanosecond resolution.

As sizeof(ktime_t) is 8 bytes, using ktime_t in 'struct sock' permits a 8 byte 
shrink of this structure on 64bit architectures. Some other structures also 
benefit from this size reduction (struct ipq in ipv4/ip_fragment.c, struct 
frag_queue in ipv6/reassembly.c, ...)


Once this ktime infrastructure adopted, we can more easily provide nanosecond 
resolution on top of it. (ioctl SIOCGSTAMPNS and/or 
SO_TIMESTAMPNS/SCM_TIMESTAMPNS)

Note : this patch includes a bug correction in compat_sock_get_timestamp() 
where a "err = 0;" was missing (so this syscall returned -ENOENT instead of 
0)

Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
CC: Stephen Hemminger <shemminger@...ux-foundation.org>
CC: John find <linux.kernel@...e.fr>

 include/linux/skbuff.h                  |   26 ++++------------------
 include/net/sock.h                      |   18 +++++++--------
 net/bridge/netfilter/ebt_ulog.c         |    6 +++--
 net/compat.c                            |   15 ++++++++----
 net/core/dev.c                          |   19 +++-------------
 net/core/sock.c                         |   16 +++++++------
 net/econet/af_econet.c                  |    2 -
 net/ipv4/ip_fragment.c                  |    6 ++---
 net/ipv4/netfilter/ip_queue.c           |    6 +++--
 net/ipv4/netfilter/ipt_ULOG.c           |    8 ++++--
 net/ipv6/exthdrs.c                      |    2 -
 net/ipv6/netfilter/ip6_queue.c          |    6 +++--
 net/ipv6/netfilter/nf_conntrack_reasm.c |    6 ++---
 net/ipv6/reassembly.c                   |    6 ++---
 net/ipx/af_ipx.c                        |    4 +--
 net/netfilter/nfnetlink_log.c           |    8 +++---
 net/netfilter/nfnetlink_queue.c         |    8 +++---
 net/packet/af_packet.c                  |    8 ++++--
 18 files changed, 80 insertions(+), 90 deletions(-)

View attachment "net_stamp_ktime.patch" of type "text/plain" (15907 bytes)