| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 02 Mar 2007 20:17:32 -0500 From: Jeff Garzik <jeff@...zik.org> To: Dale Farnsworth <dale@...nsworth.org> CC: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-mips@...ux-mips.org, Ralf Baechle <ralf@...ux-mips.org> Subject: Re: [PATCH 2/2] mv643xx_eth: Place explicit port number in mv643xx_eth_platform_data Dale Farnsworth wrote: > We were using the platform_device.id field to identify which ethernet > port is used for mv643xx_eth device. This is not generally correct. > It will be incorrect, for example, if a hardware platform uses a single > port but not the first port. Here, we add an explicit port_number field > to struct mv643xx_eth_platform_data. > > This makes the mv643xx_eth_platform_data structure required, but that > isn't an issue since all users currently provide it already. > > Signed-off-by: Dale Farnsworth <dale@...nsworth.org> > > --- > > arch/mips/momentum/jaguar_atx/platform.c | 8 ++ > arch/mips/momentum/ocelot_3/platform.c | 8 ++ > arch/mips/momentum/ocelot_c/platform.c | 4 + > arch/powerpc/platforms/chrp/pegasos_eth.c | 2 > arch/ppc/syslib/mv64x60.c | 12 +++- > drivers/net/mv643xx_eth.c | 59 ++++++++++---------- > include/linux/mv643xx.h | 1 > 7 files changed, 62 insertions(+), 32 deletions(-) ACK but not applied, patch corrupted - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists