netdev - Re: [PATCH] [USBNET] DM9501: Add Corega FEther USB-TXC support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Mar 2007 18:41:18 -0800
From:	Greg KH <greg@...ah.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	YOSHIFUJI Hideaki / ???????????? <yoshfuji@...ux-ipv6.org>,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] [USBNET] DM9501: Add Corega FEther USB-TXC support.

On Fri, Mar 02, 2007 at 08:33:55PM -0500, Jeff Garzik wrote:
> YOSHIFUJI Hideaki / ???????????? wrote:
> >Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> >---
> > drivers/usb/net/dm9601.c |    4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> >diff --git a/drivers/usb/net/dm9601.c b/drivers/usb/net/dm9601.c
> >index 4a932e1..c0bc52b 100644
> >--- a/drivers/usb/net/dm9601.c
> >+++ b/drivers/usb/net/dm9601.c
> >@@ -571,6 +571,10 @@ static const struct driver_info dm9601_info = {
> > 
> > static const struct usb_device_id products[] = {
> > 	{
> >+	 USB_DEVICE(0x07aa, 0x9601),	/* Corega FEther USB-TXC */
> >+	 .driver_info = (unsigned long)&dm9601_info,
> >+	 },
> >+	{
> 
> 
> ACK the patch, though I wonder if this shouldn't instead go to Greg.
> 
> Honestly, I would prefer that the USB net drivers were moved into 
> drivers/net with the other net drivers, /then/ I would merge such 
> patches.  We don't add drivers for PCI-based hardware to 
> drivers/pci/net, after all...

I have no objection to that.  Things have been moving out of the
drivers/usb/ directory over time, and if you want to take these under
your umbrella too, that's fine with me.

David, any objections?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html