netdev - Re: [PATCH 3/3] NetXen: Make driver use multi PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Mar 2007 20:05:16 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Linsys Contractor Mithlesh Thukral <mithlesh@...xen.com>
CC:	netdev@...r.kernel.org, netxenproj@...syssoft.com, rob@...xen.com
Subject: Re: [PATCH 3/3] NetXen: Make driver use multi PCI functions

Linsys Contractor Mithlesh Thukral wrote:
> NetXen: Make driver use multi PCI functions.
> 
> Signed-off by: Mithlesh Thukral <mithlesh@...xen.com>
> 
> ---
> 
>  netxen_nic.h          |  126 +++++-------
>  netxen_nic_ethtool.c  |   80 +++----
>  netxen_nic_hdr.h      |    8 
>  netxen_nic_hw.c       |  213 +++++++++++++++-----
>  netxen_nic_hw.h       |   18 -
>  netxen_nic_init.c     |  115 +++-------
>  netxen_nic_isr.c      |   80 +++----
>  netxen_nic_main.c     |  523 +++++++++++++++++++++++++-------------------------
>  netxen_nic_niu.c      |   27 +-
>  netxen_nic_phan_reg.h |  125 -----------
>  10 files changed, 631 insertions(+), 684 deletions(-)

all three patches in this patchset contained nothing but one-line 
summaries of the changes included in them, and are overall very poorly 
and vaguely described.

This patch is far too big, with far too little description and 
justification to go along with it.

If you are not going to make the effort to write a paragraph or two 
describing such huge changes, then I'm not going to make the effort to 
review and apply it.  NAK.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html