netdev - Re: [PATCH/RFC] Use of uninitialized data in udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070305235732.GA24642@gondor.apana.org.au>
Date:	Tue, 6 Mar 2007 10:57:32 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jim Chow <jchow@...are.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

On Tue, Mar 06, 2007 at 10:34:49AM +1100, Herbert Xu wrote:
> > 
> > That's not true.  Please see my post.
> > 
> > Specifically, at linux-2.6.20.1/net/ipv4/udp.c:843, it seems that 
> > udp_recvmsg() can randomly ignore whether the HW has computed a checksum 
> > and compute it in SW redundantly.
> 
> Sorry, you're right.  This bug has been there for years.

Actually I think we should fix UDP regardless of whether we initialise
msg_flags to zero here.  It's just too error-prone to rely on it to not
have MSG_TRUNC set.

I'm going to clean this up for UDP and improve the UDP-lite checksum
handling while I'm at it.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html