netdev - Re: [PATCH] NET : convert network timestamps to ktime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45EBBF21.1000209@cosmosbay.com>
Date:	Mon, 05 Mar 2007 07:56:33 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
CC:	shemminger@...ux-foundation.org, linux.kernel@...e.fr,
	netdev@...r.kernel.org
Subject: Re: [PATCH] NET : convert network timestamps to ktime_t

David Miller a écrit :
> From: Eric Dumazet <dada1@...mosbay.com>
> Date: Fri, 02 Mar 2007 23:46:14 +0100
> 
>> Stephen Hemminger a écrit :
>>> You missed a couple of spots.
>> Arg yes...
>  ...
>>> -	}
>>> -	skb_get_timestamp(skb, &svsk->sk_sk->sk_stamp);
>>> +	svsk->sk_sk->sk_stamp = (skb->tstamp.tv64 != 0) ? skb->tstamp
>>> +		: ktime_get_real();
>> Well, if we want to stay in the spirit of old code, we probably want to use 
>> current_kernel_time() (+ timespec_to_ktime()), because its less expensive.
>>
>> And also setting the skb tstamp, no ?
> 
> Can you guys cook up an integrated patch with all the missing cases
> fixed up as desired, so I can add this to net-2.6.22, thanks?

Yes, I will send the patch against net-2.6.22 this morning.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html