netdev - RE: [PATCH] xfrm_policy delete security check misplaced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001801c75f49$1e1989f0$cc0a010a@tcssec.com>
Date:	Mon, 5 Mar 2007 11:10:04 -0600
From:	"Venkat Yekkirala" <vyekkirala@...stedcs.com>
To:	"'James Morris'" <jmorris@...ei.org>
Cc:	"'Eric Paris'" <eparis@...isplace.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"Venkat Yekkirala" <vyekkirala@...fw4.tcs-sec.com>,
	<cxzhang@...son.ibm.com>, "Stephen Smalley" <sds@...ho.nsa.gov>
Subject: RE: [PATCH] xfrm_policy delete security check misplaced

> > > 
> > > Signed-off-by: Eric Paris <eparis@...hat.com>
> > Acked-by: Venkat Yekkirala <vyekkirala@...stedcs.com> 
> 
> What about your previous comment:
> 
>  "I guess you meant to do this here?
>         else if (err)
>                 return err; "

I saw that this was taken care of in patch-2 for the delete case, but
while err isn't currently applicable to the non-delete case, it would
be proper/complete for err to still be handled for the non-delete case.
Thanks for asking.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html