netdev - Re: [PATCH] pcnet32: only allocate init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070306183005.GA21731@verizon.net>
Date:	Tue, 6 Mar 2007 10:30:05 -0800
From:	Don Fry <pcnet32@...izon.net>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] pcnet32: only allocate init_block dma consistent

The change to use netdev_priv can only be done After moving the init
block out of the private structure.  It will break the driver if done
first, which is why they were sent together.

I will separate the changes and resend them.

On Tue, Mar 06, 2007 at 06:13:14AM -0500, Jeff Garzik wrote:
> Don Fry wrote:
> >The patch below moves the init_block out of the private struct and
> >only allocates init block with pci_alloc_consistent.
> >
> >This has two effects:
> >
> >1. Performance increase for non cache coherent machines, because the
> >   CPU only data in the private struct are now cached
> >
> >2. locks are working now for platforms, which need to have locks
> >   in cached memory
> >
> >Also use netdev_priv() instead of dev->priv
> >
> >Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> 
> please separate the netdev_priv() change into a separate, precursor 
> patch, and resend both
> 
> 
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html