[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <OF686AF962.8A54116E-ON88257296.007AF408-88257296.007BC448@us.ibm.com>
Date: Tue, 6 Mar 2007 14:32:00 -0800
From: David Stevens <dlstevens@...ibm.com>
To: "Andy Gospodarek" <andy@...yhouse.net>
Cc: bonding-devel@...ts.sourceforge.net,
"Brian Haley" <brian.haley@...com>, fubar@...ux.vnet.ibm.com,
netdev@...r.kernel.org, netdev-owner@...r.kernel.org
Subject: Re: [PATCH 3/3] bonding: Improve IGMP join processing
It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better
to call that than add a nearly identical function.
Also, real interfaces already do gratuitous IGMP advertisements when
they are bounced (the reason there is an ip_mc_up()). Could bonding,
when failing over, simply mark the master interface as down, switch, and
then mark the master as up again? In addition to doing the right
thing for both IPv4 and IPv6 multicasting w/o any code changes in those
layers, it may have similar benefits for ARP and neighbor discovery,
right?
Maybe not-- haven't looked at it...
One down side for IPv6 (which apparently bonding doesn't support) is that
static addresses are lost when the device goes down, but that's a
difference
form IPv4 that should be fixed.
+-DLS
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists