netdev - Re: [RFC PATCH]: Dynamically sized routing cache hash table.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703061023.44722.dada1@cosmosbay.com>
Date:	Tue, 6 Mar 2007 10:23:44 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Nick Piggin <npiggin@...e.de>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	robert.olsson@....uu.se, Paul McKenney <paulmck@...ibm.com>
Subject: Re: [RFC PATCH]: Dynamically sized routing cache hash table.

On Tuesday 06 March 2007 10:11, Nick Piggin wrote:

> Cool! I have some fixes for the rcu barrier issues, with some C-style
> comments and questions :)
>
> I was going to send you a fix first for the rcu barriers, then a
> second to convert the read-side to a barrier-less one that I described,
> however considering that your patch is a WIP in progress anyway, I
> won't worry too much about the normal protocol.
>
> I _think_ my reasoning regarding the rcu barriers and grace periods
> is correct. I'll keep thinking about it though. (Paul cc'ed).
>
> I'm not so familiar with this code, so I have sprinkled around a lot
> of comments that could be pure crap ;) They are mainly just to help
> you ensure that you cover all bases... compile tested only at this
> stage.

I think we missed :

+static void rt_hash_resize_work(struct work_struct *work)

+
+			*head = rth->u.dst.rt_next;
+
+			hash = rt_hashfn(rt_hash,
+					 rth->fl.fl4_dst,
+					 rth->fl.fl4_src,
+					 iface);
+			rth->u.dst.rt_next = rt_hash->table[hash].chain;
+			rt_hash->table[hash].chain = rth;

This really needs some ..._del_rcu()/..._add_rcu()_ ... primitives, no ?
Or else a reader might be very confused...

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html