netdev - Re: [patch 11/19] sis900 warning fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 06 Mar 2007 06:15:47 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org
Subject: Re: [patch 11/19] sis900 warning fixes

akpm@...ux-foundation.org wrote:
> diff -puN drivers/net/sis900.c~sis900-warning-fixes drivers/net/sis900.c
> --- a/drivers/net/sis900.c~sis900-warning-fixes
> +++ a/drivers/net/sis900.c
> @@ -1430,7 +1430,7 @@ static void sis900_auto_negotiate(struct
>  	int i = 0;
>  	u32 status;
>  
> -	while (i++ < 2)
> +	for (i = 0; i < 2; i++)
>  		status = mdio_read(net_dev, phy_addr, MII_STATUS);
>  
>  	if (!(status & MII_STAT_LINK)){

applied, though, you missed killing a redundant initialization


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html