netdev - Re: [patch 19/19] network: add the missing phy_device speed information to phy_mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45ED4EB0.9010802@garzik.org>
Date:	Tue, 06 Mar 2007 06:21:20 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org, shanlu@...uiuc.edu
Subject: Re: [patch 19/19] network: add the missing phy_device speed information
 to phy_mii_ioctl

akpm@...ux-foundation.org wrote:
> From: "Shan Lu" <shanlu@...uiuc.edu>
> 
> Function `phy_mii_ioctl' returns physical device's information based on
> user requests.  When requested to return the basic mode control register
> information (BMCR), the original implementation only returns the physical
> device's duplex information and forgets to return speed information, which
> should not be because BMCR register is used to hold both duplex and speed
> information.
> 
> The patch checks the BMCR value against speed-related flags and fills the
> return structure's speed field accordingly.
> 
> Signed-off-by: Shan <shanlu@...uiuc.edu>
> Cc: Jeff Garzik <jeff@...zik.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/phy/phy.c |    6 ++++++
>  1 file changed, 6 insertions(+)

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html