netdev - compat_sock_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1173137211.15891.27.camel@johannes.berg>
Date:	Tue, 06 Mar 2007 00:26:51 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	netdev <netdev@...r.kernel.org>
Subject: compat_sock_common_getsockopt typo?

The function reads as follows:

int compat_sock_common_getsockopt(struct socket *sock, int level, int optname,
                                  char __user *optval, int __user *optlen)
{
        struct sock *sk = sock->sk;

        if (sk->sk_prot->compat_setsockopt != NULL)
                                ^^^

                return sk->sk_prot->compat_getsockopt(sk, level, optname,
                                           ^^^
                                                      optval, optlen);
        return sk->sk_prot->getsockopt(sk, level, optname, optval, optlen);
}
EXPORT_SYMBOL(compat_sock_common_getsockopt);

Is that intentional to make protocol writers assign both if they want
compat_setsockopt? :P

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)