netdev - Re: Session ID 0 with PPPoE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070307162002.GK28150@florz.florz.dyndns.org>
Date:	Wed, 7 Mar 2007 17:20:02 +0100
From:	Florian Zumbiehl <florz@....de>
To:	Michal Ostrowski <mostrows@...thlink.net>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: Session ID 0 with PPPoE

Hi,

> This change can be made; the unbinding behavior can be removed and SID 0
> can be made valid. I hope I was clear in my previous e-mail that I
> didn't object to this.

Not quite. But now I think I got it ;-)

> PPPoE connections are unstable.  Ethernet frames get dropped.  Things
> die randomly. And yes, you typically want to have a cron job or script
> re-spawning pppd on failure.  Making this change won't increase the
> reliability of these connections in any meaningful way, it won't break
> pppd either.  

I mean, you are right from my experience that you want to have that for
pppd (which is why I _do_ have that cron job) - but your rationale
doesn't look very convincing to me. IP networks are unstable, you know.
IP packets get dropped. Things (read: TCP peers) die randomly. But no,
I don't have a cron job that restarts the MTA or web server in case some
TCP peer died - because they don't exit when some TCP connection times
out or something.

The very same thing I'd expect from pppd. If I do specify the persist
and maxfail 0 options, I expect pppd not to exit even when it receives
complete garbage from the network, much less when it receives completely
valid packets as per the RFC. The only reasonable reasons for exiting IMO
are lack of system resources or missing system features/invalid
configuration. The only reason why I do have a cron job that takes care
of restarts are all the bugs I encountered in pppd so far that caused
it to exit because it used the kernel PPP API wrongly in case of reconnects
or because it leaked ptys until there were none available anymore, not
the fact that PPP(oE) is a potentially unreliable network protocol or
because modems do lose their connection at times.

> The only question I have is why is this important to you?  I'm simply
> curious as to what you are trying to accomplish; is this related to some
> other work you are doing or is it correctness as a virtue?

It isn't extremely important to me as it doesn't affect me. But if for
any reason, then because I hope that others will take care of bugs that
they stumble across before they become a potentially difficult to solve
problem for me, too.

Florian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html