netdev - Re: [patch 12/19] fix irq problem with NAPI + NETPOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070307.151844.102573883.davem@davemloft.net>
Date:	Wed, 07 Mar 2007 15:18:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	jeff@...zik.org, netdev@...r.kernel.org, anemo@....ocn.ne.jp,
	romieu@...zoreil.com, shemminger@...ux-foundation.org
Subject: Re: [patch 12/19] fix irq problem with NAPI + NETPOLL

From: akpm@...ux-foundation.org
Date: Tue, 06 Mar 2007 02:41:56 -0800

> From: Atsushi Nemoto <anemo@....ocn.ne.jp>
> 
> It seems netif_receive_skb() was designed not to call from irq context, but
> NAPI + NETPOLL break this rule.  If netif_receive_skb() was called from irq
> context, redirect to netif_rx() instead of processing the skb in that
> context.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> Cc: Jeff Garzik <jeff@...zik.org>
> Cc: Francois Romieu <romieu@...zoreil.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

This patch can't be applied, sorry.

netpoll_rx() should be invokable from hardware interrupt context.
What is the crash you are seeing?

It looks like perhaps the kfree_skb() calls need to be modified
in __netpoll_rx().

Stephen?  Maybe this is a result of that set of cleanups you did
to the netpoll code?  It wouldn't surprise me :)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html