netdev - Re: [PATCH] Ensure IF_READY is unset when link is not ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1HP5rQ-0008RW-00@gondolin.me.apana.org.au>
Date:	Thu, 08 Mar 2007 10:47:56 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	mitch@...ux.vnet.ibm.com (Mitsuru Chinen), davem@...emloft.net,
	yoshfuji@...ux-ipv6.org
Cc:	netdev@...r.kernel.org, usagi-core@...ux-ipv6.org
Subject: Re: [PATCH] Ensure IF_READY is unset when link is not ready

Mitsuru Chinen <mitch@...ux.vnet.ibm.com> wrote:
> 
> On linux-2.6.21-rc2 or later, IPv6 link-local address is not assigned to
> some kind of interfaces during system start-up. (I found this issue
> occures with e100, e1000 and tg3.)

Here is an alternative fix.

[IPV6]: Do not set IF_READY if device is down

Now that we add the IPv6 device at registration time we don't need
to set IF_READY in ipv6_add_dev anymore because we will always get
a NETDEV_UP event later on should the device ever become ready.

Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index e16f1bb..a7fee6b 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -342,10 +342,6 @@ static struct inet6_dev * ipv6_add_dev(struct net_device *dev)
 	}
 #endif
 
-	if (netif_carrier_ok(dev))
-		ndev->if_flags |= IF_READY;
-
-
 	ipv6_mc_init_dev(ndev);
 	ndev->tstamp = jiffies;
 #ifdef CONFIG_SYSCTL
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html