netdev - Re: [PATCH] Ensure IF_READY is unset when link is not ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070308110107.6a010895.mitch@linux.vnet.ibm.com>
Date:	Thu, 8 Mar 2007 11:01:07 +0900
From:	Mitsuru Chinen <mitch@...ux.vnet.ibm.com>
To:	David Miller <davem@...emloft.net>, herbert@...dor.apana.org.au
Cc:	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
	usagi-core@...ux-ipv6.org
Subject: Re: [PATCH] Ensure IF_READY is unset when link is not ready

On Wed, 07 Mar 2007 15:54:38 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: Herbert Xu <herbert@...dor.apana.org.au>
> Date: Thu, 08 Mar 2007 10:47:56 +1100
> 
> > Mitsuru Chinen <mitch@...ux.vnet.ibm.com> wrote:
> > > 
> > > On linux-2.6.21-rc2 or later, IPv6 link-local address is not assigned to
> > > some kind of interfaces during system start-up. (I found this issue
> > > occures with e100, e1000 and tg3.)
> > 
> > Here is an alternative fix.
> > 
> > [IPV6]: Do not set IF_READY if device is down
> > 
> > Now that we add the IPv6 device at registration time we don't need
> > to set IF_READY in ipv6_add_dev anymore because we will always get
> > a NETDEV_UP event later on should the device ever become ready.
> > 
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> Indeed, this looks like it will do the right thing.
> 
> And if you look into the history of the code in this area
> I think you'll find that this snippet being removed existed
> exactly because inet6_dev creation happened long after the
> device was registered.

I understand. Thanks.
And I thank Herbert to provide suitable fix.

Best Regards,
----
Mitsuru Chinen <mitch@...ux.vnet.ibm.com>

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html