netdev - Re: [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070308.203929.123921762.davem@davemloft.net>
Date:	Thu, 08 Mar 2007 20:39:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps
 with nanosec resolution

From: Eric Dumazet <dada1@...mosbay.com>
Date: Thu, 8 Mar 2007 15:17:57 +0100

> [PATCH] NET : Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec 
> resolution
> 
> Now network timestamps use ktime_t infrastructure, we can add a new ioctl() 
> SIOCGSTAMPNS  command to get timestamps in 'struct timespec'.
> User programs can thus access to nanosecond resolution.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
> CC: Stephen Hemminger <shemminger@...ux-foundation.org>

Applied, thanks Eric.

This patch points out a potential compat layer problem which sh64.  It
defines the SIOCGSTAMP (and not SIOCGSTAMPNS) ioctls as not constants,
but rather constant values that depend upon the size of the structure
passed in.

But the compat bridges for these timestamp ioctls simply match on the
native ioctl value and then pass it in unchanged to the real handler.
That won't work for sh64 compat layer for 32-bit sh applications.

That's what they get for being different :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html