netdev - Re: [PATCH 2/5] NetXen: Update the statistics counter for interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45F18A73.1080801@linux-foundation.org>
Date:	Fri, 09 Mar 2007 08:25:23 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Linsys Contractor Mithlesh Thukral <mithlesh@...xen.com>
CC:	netdev@...r.kernel.org, amitkale@...xen.com, jeff@...zik.org,
	netxenproj@...syssoft.com, rob@...xen.com
Subject: Re: [PATCH 2/5] NetXen: Update the statistics counter for interrupts

Linsys Contractor Mithlesh Thukral wrote:
> NetXen: Update the statistics counter for interrupts which have occured.
>
> Signed-off-by: Mithlesh Thukral <mithlesh@...xen.com>
> ---
>
>  drivers/net/netxen/netxen_nic_main.c |    1 +
>  1 files changed, 1 insertion(+)
>
> diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
> index bfeca9a..5fbf6b0 100644
> --- a/drivers/net/netxen/netxen_nic_main.c
> +++ b/drivers/net/netxen/netxen_nic_main.c
> @@ -1023,6 +1023,7 @@ netxen_handle_int(struct netxen_adapter 
>  	u32 ret = 0;
>  
>  	DPRINTK(INFO, "Entered handle ISR\n");
> +	adapter->stats.ints++;
>  
>   
You may want to consider the cost of the additional cache miss.
Either don't bother with this stat, or go to per-cpu stats.
Plus isn't this already in the statistics kept for /proc/interrupts?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html