netdev - Re: [PATCH 04/18][SK_BUFF]: Introduce skb_reset_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39e6f6c70703120314m1907f4d5sa33522efb14d220c@mail.gmail.com>
Date:	Mon, 12 Mar 2007 07:14:08 -0300
From:	"Arnaldo Carvalho de Melo" <acme@...stprotocols.net>
To:	"Christoph Hellwig" <hch@...radead.org>
Cc:	"David Miller" <davem@...emloft.net>,
	"Netdev List" <netdev@...r.kernel.org>
Subject: Re: [PATCH 04/18][SK_BUFF]: Introduce skb_reset_network_header(skb)

On 3/12/07, Christoph Hellwig <hch@...radead.org> wrote:
> On Mon, Mar 12, 2007 at 01:26:52AM -0300, Arnaldo Carvalho de Melo wrote:
> > For the common, open coded 'skb->nh.raw = skb->data' operation, so that we
> > can
> > later turn skb->nh.raw into a offset, reducing the size of struct sk_buff in
> > 64bit land while possibly keeping it as a pointer on 32bit.
> >
> > This one touches just the most simple case, next will handle the slightly
> > more
> > "complex" cases.
>
> I don't like the naming.  Either it should skb_reset_nh to match the field
> name (with a good kdoc comment explaning what nh means), or the field
> name should be network_header aswell.  In general I'd prefer the shorter
> names.

The fields will be renamed down the line, when their life as a union
of pointers will end, becoming just offsets.

> But besides the naming issue this looks like a very nice way to go down.

:-)

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html