netdev - Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070312.135444.63738960.davem@davemloft.net>
Date:	Mon, 12 Mar 2007 13:54:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	penberg@...helsinki.fi
Cc:	jarkao2@...pl, amit2030@...il.com, linux-kernel@...r.kernel.org,
	akpm@...l.org, netdev@...r.kernel.org
Subject: Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check
 kmalloc() return value.

From: "Pekka Enberg" <penberg@...helsinki.fi>
Date: Mon, 12 Mar 2007 14:36:46 +0200

> On 3/12/07, Jarek Poplawski <jarkao2@...pl> wrote:
> > So, maybe it's less evil to check those NULLs where possible and add
> > some WARN_ONs here and there...
> 
> No, it's much better to oops rather than paper over a bug.

The caller is going to OOPS in this case if you return after an
allocation failure, so there is no improvement after the patch.

Multipath-cached just sucks, it was thrown over the wall by IBM
Germany then never had any followon maintainence at all, so it will be
removed unless someone steps up to seriously maintain and fix that
code, and I REALLY MEAN IT.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html