netdev - Re: [PATCH 4/4] PPPoE: race between interface going down and release()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2007 06:08:36 +0100
From:	Florian Zumbiehl <florz@...rz.de>
To:	Michal Ostrowski <mostrows@...thlink.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/4] PPPoE: race between interface going down and release()

Hi,

> Attached below is my take on how to address this problem.  
> This addresses any concerns you may have had about checking po->pppoe_dev==NULL,
> because accesses to this field are now synchronized with pppoe_hash_lock.

That indeed looks like a much cleaner solution, so I'd certainly prefer
it over mine. Testing so far didn't turn up any problems, either.

> Once we can settle on a fix for this, I'll deal with the SID==0 issue 
> (trying to do that now would just cause patch conflicts).

Well, yeah, this stuff probably is more important than support
for SID 0 :-)

Florian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html