netdev - Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bffcb0e0703131126l724c2a2eh6e1b9bb22c0e40c7@mail.gmail.com>
Date:	Tue, 13 Mar 2007 19:26:27 +0100
From:	"Michal Piotrowski" <michal.k.k.piotrowski@...il.com>
To:	"Tejun Heo" <htejun@...il.com>
Cc:	"Stephen Hemminger" <shemminger@...ux-foundation.org>,
	tglx@...utronix.de, "Jeff Garzik" <jeff@...zik.org>,
	linux-ide@...r.kernel.org, "Ingo Molnar" <mingo@...e.hu>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>,
	netdev@...r.kernel.org, "Alan Cox" <alan@...rguk.ukuu.org.uk>
Subject: Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

On 12/03/07, Tejun Heo <htejun@...il.com> wrote:
> Stephen Hemminger wrote:
> > On Tue, 13 Mar 2007 04:03:00 +0900
> > Tejun Heo <htejun@...il.com> wrote:
> >
> >> Stephen Hemminger wrote:
> >>>> 1. the controller has IRQ stuck high (infrequent but possible)
> >>>> 2. the IRQ is already requested by another device
> >>>> 3. the IRQ gets disabled due to screaming interrupts at the moment
> >>>> ata_piix does pci_enable_device().
> >>>>
> >>>> I think we can be much more resilient to screaming interrupts if we
> >>>> enable device with IRQ disabled and enable it after the device is
> >>>> initialized to some level, possibly when requesting IRQ.
> >>> The first thing the skge driver does is do a chip reset, and that should
> >>> cause IRQ to be disabled and cleared. The driver has no chance to
> >>> fix it if the BIOS left the IRQ screaming...
> >> What if we do something like...
> >>
> >>      pci_intx(pdev, 0);
> >>      pci_enable_device(pdev);
> >>      /* initialize */
> >>      request_irq(blah blah...);
> >>      pci_intx(pdev, 1);
> >>
> >> Would this work for skge?
> >>
> >
> > Okay for testing, but any change like this should be done in the base
> > PCI layer, not one off in a particular driver.
>
> Yeap, it was a proof-of-concept pseudo code.  I attached a patch to do
> above in skge.  Please point out if it is broken (e.g. intx needs to be
> enabled earlier).
>
> Michal, can you apply the attached patch and see whether it fixes the
> problem.

I think that problem is solved.

Thanks.

>
> Thanks.
>
> --
> tejun
>
> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> index eea75a4..2c990f2 100644
> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c
> @@ -3585,6 +3585,7 @@ static int __devinit skge_probe(struct pci_dev *pdev,
>         struct skge_hw *hw;
>         int err, using_dac = 0;
>
> +       pci_intx(pdev, 0);
>         err = pci_enable_device(pdev);
>         if (err) {
>                 dev_err(&pdev->dev, "cannot enable PCI device\n");
> @@ -3669,6 +3670,7 @@ static int __devinit skge_probe(struct pci_dev *pdev,
>                        dev->name, pdev->irq);
>                 goto err_out_unregister;
>         }
> +       pci_intx(pdev, 1);
>         skge_show_addr(dev);
>
>         if (hw->ports > 1 && (dev1 = skge_devinit(hw, 1, using_dac))) {
>
>

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html