netdev - Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070313120418.554a3a43@freekitty>
Date:	Tue, 13 Mar 2007 12:04:18 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	linux-mips@...ux-mips.org, ralf@...ux-mips.org,
	netdev@...r.kernel.org, jeff@...zik.org, sshtylyov@...mvista.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

On Wed, 14 Mar 2007 01:02:20 +0900 (JST)
Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:

> The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on
> receiving.  Recent fix of MIPS dma_sync_single_for_cpu() reveal this
> bug.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>
> ---
> This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2.
> 
> diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c
> index ec888db..eed78b5 100644
> --- a/drivers/net/tc35815.c
> +++ b/drivers/net/tc35815.c
> @@ -58,12 +58,13 @@
>   *	1.34	Fix netpoll locking.  "BH rule" for NAPI is not enough with
>   *		netpoll, hard_start_xmit might be called from irq context.
>   *		PM support.
> + *	1.35	Fix an usage of streaming DMA API.
>   */

Please don't use comments as changelog anymore. It gets out of date.
The use of change control systems has made this practice obsolete.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html