netdev - Re: [RFC] [PATCH] Network Events Connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070314.181751.41635171.davem@davemloft.net>
Date:	Wed, 14 Mar 2007 18:17:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sam@...ack.fr
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] [PATCH] Network Events Connector

From: Samir Bellabes <sam@...ack.fr>
Date: Thu, 15 Mar 2007 02:05:53 +0100

> +#if 0
> +#define DEBUGP printk
> +#else
> +#define DEBUGP(format, args...)
> +#endif

Please no local debugging macros.

> +static unsigned int is_same_event(struct event one, struct event two) {

Please format functions properly, especially wrt. braces, they don't
belong on the line holding the argument list closing parenthesis:

return_type func_name(args)
{
}

I'm not going to read this any further, please master
Documentation/CodingStyle and resubmit if you want further
review from me.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html