netdev - Re: [PATCH] skge: set mac address bonding fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45F959A7.1090604@pobox.com>
Date:	Thu, 15 Mar 2007 10:35:19 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
CC:	Chris Stromsoe <cbs@....ucla.edu>, Jay Vosburgh <fubar@...ibm.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] skge: set mac address bonding fix

Stephen Hemminger wrote:
> When bonding does fail over it calls set_mac_address.  When this happens
> as the result of another port going down, the phy_mutex that is common to
> both ports is held, so it deadlocks. Setting the address doesn't need to do
> anything that needs the phy_mutex, it already has the RTNL to protect against
> other admin actions.
> 
> This change just disables the receiver to avoid any hardware confusion
> while address is changing.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux-foundation.org>

applied, because:

Rather than guessing about whether hardware confusion would occur, it is 
best to disable the receiver (for any hardware) unless we are CERTAIN 
that the hardware RX filter can be updated without stopping RX.

Motivated people should check this on other hardware too.

	Jeff




-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html