lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Mar 2007 13:38:24 +0000 From: Christoph Hellwig <hch@...radead.org> To: David Howells <dhowells@...hat.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, herbert.xu@...hat.com, linux-kernel@...r.kernel.org, hch@...radead.org, arjan@...radead.org Subject: Re: [PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC [try #2] On Fri, Mar 16, 2007 at 12:50:31PM +0000, David Howells wrote: > Export the keyring key type definition. > > Add extra alternative types into the key's type_data union to make it more > useful. You wrote the code so there must be some reason for this, but these changes look rather odd to me :) > diff --git a/security/keys/keyring.c b/security/keys/keyring.c > index ad45ce7..88292e3 100644 > --- a/security/keys/keyring.c > +++ b/security/keys/keyring.c > @@ -66,6 +66,8 @@ struct key_type key_type_keyring = { > .read = keyring_read, > }; > > +EXPORT_SYMBOL(key_type_keyring); > + Having a type exported is really odd, how is this supposed to be a public API? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists