netdev - Re: [PATCH] fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2007 14:41:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Robert.Olsson@...a.slu.se
Cc:	netdev@...r.kernel.org, kaber@...sh.net, tgr@...g.ch,
	Jens.Laas@...a.slu.se, hans.liss@....uu.se
Subject: Re: [PATCH] fib_hash removal

From: Robert Olsson <Robert.Olsson@...a.slu.se>
Date: Fri, 16 Mar 2007 13:38:31 +0100

> 
> Hello, Just discussed this Patrick...
> 
> We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete 
> both are holding RTNL. So there shouldn't be need for this preempt stuff. 
> This is assumed to a leftover from an older RCU-take.
> 
> > Mhh .. I think I just remembered something - me incorrectly suggesting
> > to add it there while we were talking about this at OLS :) IIRC the
> > idea was to make sure tnode_free (which at that time didn't use
> > call_rcu) wouldn't free memory while still in use in a rcu read-side
> > critical section. It should have been synchronize_rcu of course,
> > but with tnode_free using call_rcu it seems to be completely
> > unnecessary. So I guess we can simply remove it.
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>
> Signed-off-by: Robert Olsson <robert.olsson@....uu.se>

Applied, thanks a lot.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html