netdev - Re: [PATCH] [SK_BUFF]: Disable the offset code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070316.185310.48528040.davem@davemloft.net>
Date:	Fri, 16 Mar 2007 18:53:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	acme@...stprotocols.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [SK_BUFF]: Disable the offset code

From: "Arnaldo Carvalho de Melo" <acme@...stprotocols.net>
Date: Fri, 16 Mar 2007 22:42:46 -0300

>         Please pull from:
> 
> master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
> 
>         Till I fully investigate and fix this we should just use the
> pointer based approach, where this problem bug doesn't happens, good
> thing its selectable :)

Pulled, let me know when you have a real fix :-)

For others, Arnaldo and I suspect that the failure case is
when an offset is negative.  Since the offsets are unsigned
and 32-bit this will do the wrong thing when used as an
offset of a 64-bit pointer as the 32-bit "negative" value
will be zero instead of sign-extended.

If this theory proves true, the fix is to make the offsets
signed 32-bit quantities.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html