netdev - Re: [patch 4/6] [TULIP] Quiet down tulip_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 17 Mar 2007 13:05:56 -0600
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Valerie Henson <val_henson@...ux.intel.com>, akpm@...l.org,
	netdev@...r.kernel.org, Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [patch 4/6] [TULIP]  Quiet down tulip_stop_rxtx

On Thu, Mar 15, 2007 at 11:25:10AM -0400, Jeff Garzik wrote:
...
> Here's the problem with this:  this printk is signalling that the DMA 
> engines have not yet stopped, which is an event of which we should be wary.
> 
> While it makes sense to do this patch, since the complaining cards 
> appear to work anyway, we also need to take into account the times when 
> this is not a spurious warning.

It's certainly not spurious warning when in the "unload driver module" path.
This is when the driver unmaps the control data and the particular packet
it's doing DMA to. 

> Thus, I would consider maybe adding a warning somewhere in the 
> DMA-engine-start region of code, that complains if the DMA engines are 
> already active, or somesuch.

Sure. But also in the shutdown path where we unmap any DMA mappings.

thanks,
grant
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html