netdev - Re: [PATCH 1/1] [SK_BUFF]: Don't apply the offset of two allocations to the layer headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39e6f6c70703172023g1fdf736et21be456106983f80@mail.gmail.com>
Date:	Sun, 18 Mar 2007 00:23:05 -0300
From:	"Arnaldo Carvalho de Melo" <acme@...stprotocols.net>
To:	"David S. Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] [SK_BUFF]: Don't apply the offset of two allocations to the layer headers

On 3/18/07, Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:
> On 3/18/07, Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:
> >
> > Hi David,
> >
> >         Here is the bugger, it wasn't because {transport,network,mac}_header
> > is unsigned after all :-)
> >
> >         Please consider pulling from the usual place:
> >
> > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
> >
> >         Please lemme know how longer it takes to crash your workstation, I hope
> > not before next century 8-)
> >
> > - Arnaldo
> >
> > ---
> > In pskb_expand_head and copy_skb_header (used in p?skb_copy(expand)?) the
> > difference of two allocations were being applied to
> > ->(transport|network|mac)_header, when this is not only not needed but causes
> > problems, as those headers are now just offsets from ->head.
> >
> > This fixes the problem with xfrm (skb_copy_checksum was the first place this
>
> Argh, skb_checksum_help! lemme fix this comment before its too late...

Done!

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html