netdev - Re: [PATCH] Netpoll support for Sibyte MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46002989.5000609@ru.mvista.com>
Date:	Tue, 20 Mar 2007 21:35:53 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	dsaxena@...xity.net, netdev@...r.kernel.org, ralf@...ux-mips.org,
	jeff@...zik.org, linux-mips@...ux-mips.org, mlachwani@...sta.com
Subject: Re: [PATCH] Netpoll support for Sibyte MAC

Hello.

Atsushi Nemoto wrote:

>>NETPOLL support for Sibyte MAC

>>Signed-off-by: Manish Lachwani <mlachwani@...sta.com>
>>Signed-off-by: Deepak Saxena <dsaxena@...sta.com>

> If you added NETPOLL support, do not forget to ensure hard_start_xmit
> routine callable from interrupt context (or irq disabled).
> See commit bce305f4fe779f29d99d414685243f5da0803254 for example.

    You're absolutely right: this driver is very likely to blow up the caller 
when called with interrupts disabled -- it uses spin_unlock_irq() there! This 
*must* be fixed.

> ---
> Atsushi Nemoto

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html