netdev - Re: [ANN] Unified dynamic storage for different socket types instead of separate hash tables.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070322.122120.115923509.davem@davemloft.net>
Date:	Thu, 22 Mar 2007 12:21:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	johnpol@....mipt.ru
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: [ANN] Unified dynamic storage for different socket types
 instead of separate hash tables.

From: Evgeniy Polyakov <johnpol@....mipt.ru>
Date: Thu, 22 Mar 2007 22:14:49 +0300

> And to be absolutely clear - existing interface does not support it too
> - we iterate over every single hash entry, and then over every single
> item in the chain (if it exists). I can create the same for the tree -
> it is not complex at all, but it is not the most optimal solution, and 
> since I remove several entries, I think it is not that bad to remove a 
> bit less and optimize 'iterate over all object' case a bit.

This results in your trie having two new run-time costs:

1) More expensive trie insert/delete compared to hash
   insert/delete

2) An extra list insert/delete to give list of all sockets

So connection setup/teardown will be more expensive and
therefore our connection rates will be lower.

Evgeniy, your ideas are beautiful in theory, but all the details
kill all of your non-trivial work and make it useless in the end.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html