[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070322.140816.104054993.davem@davemloft.net>
Date: Thu, 22 Mar 2007 14:08:16 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: kaber@...sh.net
Cc: shemminger@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH 4/5] netem: avoid excessive requeues
From: Patrick McHardy <kaber@...sh.net>
Date: Thu, 22 Mar 2007 21:40:43 +0100
> > --- net-2.6.22.orig/net/sched/sch_netem.c
> > +++ net-2.6.22/net/sched/sch_netem.c
> > @@ -272,6 +272,10 @@ static struct sk_buff *netem_dequeue(str
> > struct netem_sched_data *q = qdisc_priv(sch);
> > struct sk_buff *skb;
> >
> > + smp_mb();
> > + if (sch->flags & TCQ_F_THROTTLED)
> > + return NULL;
> > +
>
>
> Perhaps we should put this in qdisc_restart, other qdiscs have the
> same problem.
Agreed, patches welcome :)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists