netdev - Re: [NET_SCHED 01/11]: sch_netem: fix off-by-one in send time comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070323093435.2402404f@freekitty>
Date:	Fri, 23 Mar 2007 09:34:35 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [NET_SCHED 01/11]: sch_netem: fix off-by-one in send time
 comparison

On Fri, 23 Mar 2007 14:35:40 +0100 (MET)
Patrick McHardy <kaber@...sh.net> wrote:

> [NET_SCHED]: sch_netem: fix off-by-one in send time comparison
> 
> netem checks PSCHED_TLESS(cb->time_to_send, now) to find out whether it is
> allowed to send a packet, which is equivalent to cb->time_to_send < now.
> Use !PSCHED_TLESS(now, cb->time_to_send) instead to properly handle
> cb->time_to_send == now.
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>
>

Thanks, I saw that earlier in another spot and fixed it.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html