netdev - Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46059EF8.6050603@trash.net>
Date:	Sat, 24 Mar 2007 22:58:16 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	James Chapman <jchapman@...alix.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

James Chapman wrote:
> [PPPOL2TP]: Add PPP-over-L2TP driver core.

A couple more comments:

- seq_file handling doesn't check seq_printf return values and
  tries to dump the entire hash table at once, which might
  exceed the available room.

- there appear to be no checks for duplicate session IDs on
  session creation.

- try_module_get/put_module in pppol2tp_create look unnecessary

- kfree can take NULL pointers

- direct dereference of user pointer in pppol2tp_sendmsg debugging

- jiffies.h includes conversion functions for HZ <-> msecs

- Any particular reason why the SKB_CB is put after inet_skb_parm?
  On 64 bit this almost reaches the limit, might be safer to put
  it at the beginning.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html