netdev - Re: [PATCH 0/3]: Further reduction of direct access to skb->data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070324.202018.41636403.davem@davemloft.net>
Date:	Sat, 24 Mar 2007 20:20:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	acme@...stprotocols.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/3]: Further reduction of direct access to skb->data

From: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Date: Sat, 24 Mar 2007 18:07:06 -0300

> Hi David,
> 
> 	Please take a look, at first I thought about adding a skb_copy_{from,to}_data,
> that would do just the memcpy, but then skb_{copy,store}_bits seems to be fit for this
> purpose, but its more costly in some cases, comments?
> 
> 	Available at:
> 
> master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
> 

I think you should make the named alias for direct memcpy()
instead, call it skb_copy_{from,to}_linear_data() so that the
assumed invariant is well documented.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html