netdev - Re: [TG3 2/3]: Exit irq handler during chip reset.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070324.205826.59027243.davem@davemloft.net>
Date:	Sat, 24 Mar 2007 20:58:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	bwalle@...e.de, netdev@...r.kernel.org
Subject: Re: [TG3 2/3]: Exit irq handler during chip reset.

From: "Michael Chan" <mchan@...adcom.com>
Date: Fri, 23 Mar 2007 16:13:07 -0800

> [TG3]: Exit irq handler during chip reset.
> 
> On most tg3 chips, the memory enable bit in the PCI command register
> gets cleared during chip reset and must be restored before accessing
> PCI registers using memory cycles.  The chip does not generate
> interrupt during chip reset, but the irq handler can still be called
> because of irq sharing or irqpoll.  Reading a register in the irq
> handler can cause a master abort in this scenario and may result in a
> crash on some architectures.
> 
> Use the TG3_FLAG_CHIP_RESETTING flag to tell the irq handler to exit
> without touching any registers.  The checking of the flag is in the
> "slow" path of the irq handler and will not affect normal performance.
> The msi handler is not shared and therefore does not require checking
> the flag.
> 
> Thanks to Bernhard Walle <bwalle@...e.de> for reporting the problem.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied, except I fixed up some weird tabbing on this line:

> @@ -3568,32 +3568,34 @@ static irqreturn_t tg3_interrupt(int irq, void *dev_id)
 ...
> +	} else {
> +		/* No work, shared interrupt perhaps?  re-enable
> +		 * interrupts, and flush that PCI write
> +		 */
> +		tw32_mailbox_f(MAILBOX_INTERRUPT_0 + TG3_64BIT_REG_LOW,
> +		     	0x00000000);
                ^^^^^^^^

There are two tabs, some space characters, then a final tab,
and it doesn't even make the argument match up to the openning
parenthesis on the previous line :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html