[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070325.183700.118526082.davem@davemloft.net>
Date: Sun, 25 Mar 2007 18:37:00 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: paulus@...ba.org
Cc: gl@...-ac.de, samuel@...tiz.org, irda-users@...ts.sourceforge.net,
netdev@...r.kernel.org
Subject: Re: [irda-users] [2.6.20-rt8] "Neighbour table overflow."
From: Paul Mackerras <paulus@...ba.org>
Date: Mon, 26 Mar 2007 11:02:22 +1000
> David Miller writes:
>
> > The PPP generic layer seems to be very careful about it's handling of
> > the ->xmit_pending packet.
>
> Mostly, but I think that this is a genuine leak.
>
> > I'm really surprised this leak doesn't trigger already via the
> > ppp_synctty.c and ppp_async.c drivers, perhaps they do something to
> > make sure the transmitter gets purged properly when unregistering and
> > therefore ->xmit_pending does not get left non-NULL at unregister
> > time.
>
> At least for ppp_async, I think what saves us is that pppd does a
> TCFLSH ioctl when shutting down the link, which calls
> ppp_async_flush_output, which calls ppp_output_wakeup.
Ok, that makes sense, I'll apply the leak fix for sure
especially since I even have your ACK now :-)
Thanks for reviewing Paul.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists