netdev - Re: [PATCH 2/2] [SK_BUFF]: Introduce skb_copy_from_linear_data{

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Mar 2007 23:35:07 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] [SK_BUFF]: Introduce skb_copy_from_linear_data{_offset}

Arnaldo Carvalho de Melo wrote:
> On 3/27/07, Patrick McHardy <kaber@...sh.net> wrote:
> 
>> nf_nat_helper.c:mangle_content() could make use of this, but it
>> would need memmove. Something to do this with non-linear packets
>> would be even cooler :)
> 
> 
> Damn, that was so fast man! For the qeth case that motivated me to try
> the leftover it was like: memcpy is the fastest way, memmove would be
> more costly but more general, when in doubt I just droppped the users
> without removing the infrastructure, nah, lets leave this for another
> day, for now I'll just drop the non-used -new infrastrucure and
> resubmit.


Yes, as long as it doesn't help with anything else it doesn't seem
too useful. It did motivate me to try the non-linear skb mangling
though :)

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html