netdev - Re: [PATCH] NET : inet_ehash_secret should be __read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 27 Mar 2007 23:03:06 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET : inet_ehash_secret should be __read_mostly and set
 only once

David Miller a écrit :
> From: Eric Dumazet <dada1@...mosbay.com>
> Date: Tue, 27 Mar 2007 12:13:43 +0200
> 
>> Hi David
>>
>> Please find this patch against net-2.6.22
>>
>> Thank you
>>
>> [PATCH] NET : inet_ehash_secret should be __read_mostly and set only once
>>
>> There is a very tiny probability that build_ehash_secret() is called at the same time by different CPUS.
>>
>> Also, using __read_mostly is a must for inet_ehash_secret
>>
>> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
> 
> Applied, but I left out this totally unrelated code formatting
> change in your patch:
> 
>> @@ -684,7 +694,8 @@ int inet_sendmsg(struct kiocb *iocb, str
>>  }
>>  
>>  
>> -static ssize_t inet_sendpage(struct socket *sock, struct page *page, int offset, size_t size, int flags)
>> +static ssize_t inet_sendpage(struct socket *sock, struct page *page, int offset,
>> +	size_t size, int flags)
>>  {
>>  	struct sock *sk = sock->sk;
>>  

Well... just a minor change to reduce length of this too long line...

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html