netdev - Re: [PATCH 2/2] [SK_BUFF]: Introduce skb_copy_from_linear_data{

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070327.140749.106434705.davem@davemloft.net>
Date:	Tue, 27 Mar 2007 14:07:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	acme@...stprotocols.net
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] [SK_BUFF]: Introduce
 skb_copy_from_linear_data{_offset}

From: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Date: Tue, 27 Mar 2007 16:41:48 -0300

> +static inline void skb_move_linear_data(const struct sk_buff *skb,
> +					const int from_offset,
> +					const int to_offset,
> +					const unsigned int len)
> +{
> +	memcpy(skb->data + to_offset, skb->data + from_offset, len);
> +}
> +

What do you intend to use this for?  There are no users in
your patch, and I'd be fearful of overlapping cases (which
ought to be common for anything using this) which therefore
would require use of memmove() instead of memcpy().

How about we just leave out interfaces until we have a use
case?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html